Moving RuntimeMLIRCommonImpl.h into .cpp files#3976
Merged
Renaud-K merged 1 commit intoNVIDIA:mainfrom Feb 17, 2026
Merged
Conversation
Signed-off-by: Renaud Kauffmann <rkauffmann@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
lmondada
approved these changes
Feb 17, 2026
Collaborator
lmondada
left a comment
lmondada
left a comment
There was a problem hiding this comment.
I admit I didn't go through the diffs carefully -- I trust that you've just moved stuff around and into cpp files, which is always good.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuntimeMLIRCommonImpl.hwas used to share code between theBaseRemoteRESTQPUand thePyBaseRemoteRESTQPU. Now that the python versions of the Remote QPUs are gone, this can be moved back into an implementation file. There is no need to make all this implementation transitively visible in header files. The interfaces ofRuntimeMLIR.handJIT.hsuffice.Code in
RuntimeMLIRCommonImpl.hhas been moved into eitherJIT.cpporRuntimeMLIR.cpp.